diff options
author | Antonio Nino Diaz <antonio.ninodiaz@arm.com> | 2018-12-14 00:18:21 +0000 |
---|---|---|
committer | Antonio Nino Diaz <antonio.ninodiaz@arm.com> | 2019-01-04 10:43:17 +0000 |
commit | 09d40e0e08283a249e7dce0e106c07c5141f9b7e (patch) | |
tree | 46e7af7b5be2738948b359b2a07078e4cf1bbec1 /plat/rockchip/common | |
parent | f5478dedf9e096d9539362b38ceb096b940ba3e2 (diff) | |
download | trusted-firmware-a-09d40e0e08283a249e7dce0e106c07c5141f9b7e.tar.gz |
Sanitise includes across codebase
Enforce full include path for includes. Deprecate old paths.
The following folders inside include/lib have been left unchanged:
- include/lib/cpus/${ARCH}
- include/lib/el3_runtime/${ARCH}
The reason for this change is that having a global namespace for
includes isn't a good idea. It defeats one of the advantages of having
folders and it introduces problems that are sometimes subtle (because
you may not know the header you are actually including if there are two
of them).
For example, this patch had to be created because two headers were
called the same way: e0ea0928d5b7 ("Fix gpio includes of mt8173 platform
to avoid collision."). More recently, this patch has had similar
problems: 46f9b2c3a282 ("drivers: add tzc380 support").
This problem was introduced in commit 4ecca33988b9 ("Move include and
source files to logical locations"). At that time, there weren't too
many headers so it wasn't a real issue. However, time has shown that
this creates problems.
Platforms that want to preserve the way they include headers may add the
removed paths to PLAT_INCLUDES, but this is discouraged.
Change-Id: I39dc53ed98f9e297a5966e723d1936d6ccf2fc8f
Signed-off-by: Antonio Nino Diaz <antonio.ninodiaz@arm.com>
Diffstat (limited to 'plat/rockchip/common')
-rw-r--r-- | plat/rockchip/common/aarch64/plat_helpers.S | 5 | ||||
-rw-r--r-- | plat/rockchip/common/aarch64/platform_common.c | 17 | ||||
-rw-r--r-- | plat/rockchip/common/bl31_plat_setup.c | 20 | ||||
-rw-r--r-- | plat/rockchip/common/drivers/parameter/ddr_parameter.c | 16 | ||||
-rw-r--r-- | plat/rockchip/common/drivers/parameter/ddr_parameter.h | 15 | ||||
-rw-r--r-- | plat/rockchip/common/include/plat_macros.S | 8 | ||||
-rw-r--r-- | plat/rockchip/common/include/plat_private.h | 8 | ||||
-rw-r--r-- | plat/rockchip/common/params_setup.c | 18 | ||||
-rw-r--r-- | plat/rockchip/common/plat_pm.c | 15 | ||||
-rw-r--r-- | plat/rockchip/common/plat_topology.c | 6 | ||||
-rw-r--r-- | plat/rockchip/common/rockchip_gicv2.c | 9 | ||||
-rw-r--r-- | plat/rockchip/common/rockchip_gicv3.c | 11 | ||||
-rw-r--r-- | plat/rockchip/common/rockchip_sip_svc.c | 10 |
13 files changed, 92 insertions, 66 deletions
diff --git a/plat/rockchip/common/aarch64/plat_helpers.S b/plat/rockchip/common/aarch64/plat_helpers.S index f0136b0d91..4af052b574 100644 --- a/plat/rockchip/common/aarch64/plat_helpers.S +++ b/plat/rockchip/common/aarch64/plat_helpers.S @@ -4,13 +4,14 @@ * SPDX-License-Identifier: BSD-3-Clause */ +#include <platform_def.h> + #include <arch.h> #include <asm_macros.S> -#include <bl_common.h> +#include <common/bl_common.h> #include <cortex_a53.h> #include <cortex_a72.h> #include <plat_private.h> -#include <platform_def.h> #include <plat_pmu_macros.S> .globl cpuson_entry_point diff --git a/plat/rockchip/common/aarch64/platform_common.c b/plat/rockchip/common/aarch64/platform_common.c index 9a74314c94..81e8520626 100644 --- a/plat/rockchip/common/aarch64/platform_common.c +++ b/plat/rockchip/common/aarch64/platform_common.c @@ -4,15 +4,18 @@ * SPDX-License-Identifier: BSD-3-Clause */ +#include <string.h> + +#include <platform_def.h> + #include <arch_helpers.h> -#include <bl_common.h> -#include <cci.h> -#include <debug.h> +#include <common/bl_common.h> +#include <common/debug.h> +#include <drivers/arm/cci.h> +#include <lib/utils.h> +#include <lib/xlat_tables/xlat_tables.h> + #include <plat_private.h> -#include <platform_def.h> -#include <string.h> -#include <utils.h> -#include <xlat_tables.h> #ifdef PLAT_RK_CCI_BASE static const int cci_map[] = { diff --git a/plat/rockchip/common/bl31_plat_setup.c b/plat/rockchip/common/bl31_plat_setup.c index 7a9f7a9d10..2c970eb8a6 100644 --- a/plat/rockchip/common/bl31_plat_setup.c +++ b/plat/rockchip/common/bl31_plat_setup.c @@ -5,16 +5,18 @@ */ #include <assert.h> -#include <bl_common.h> -#include <console.h> -#include <coreboot.h> -#include <debug.h> -#include <generic_delay_timer.h> -#include <mmio.h> -#include <plat_private.h> -#include <platform.h> + #include <platform_def.h> -#include <uart_16550.h> + +#include <common/bl_common.h> +#include <common/debug.h> +#include <drivers/console.h> +#include <drivers/generic_delay_timer.h> +#include <drivers/ti/uart/uart_16550.h> +#include <lib/coreboot.h> +#include <lib/mmio.h> +#include <plat_private.h> +#include <plat/common/platform.h> /* * The next 2 constants identify the extents of the code & RO data region. diff --git a/plat/rockchip/common/drivers/parameter/ddr_parameter.c b/plat/rockchip/common/drivers/parameter/ddr_parameter.c index ea77757f7b..e89fe1e029 100644 --- a/plat/rockchip/common/drivers/parameter/ddr_parameter.c +++ b/plat/rockchip/common/drivers/parameter/ddr_parameter.c @@ -4,15 +4,19 @@ * SPDX-License-Identifier: BSD-3-Clause */ +#include <string.h> + +#include <platform_def.h> + #include <arch_helpers.h> -#include <console.h> -#include <debug.h> -#include <delay_timer.h> -#include <mmio.h> +#include <common/debug.h> +#include <drivers/console.h> +#include <drivers/delay_timer.h> +#include <lib/mmio.h> + #include <plat_private.h> -#include <platform_def.h> #include <soc.h> -#include <string.h> + #include "ddr_parameter.h" /* diff --git a/plat/rockchip/common/drivers/parameter/ddr_parameter.h b/plat/rockchip/common/drivers/parameter/ddr_parameter.h index 69c4e18bdc..61349c44cf 100644 --- a/plat/rockchip/common/drivers/parameter/ddr_parameter.h +++ b/plat/rockchip/common/drivers/parameter/ddr_parameter.h @@ -7,15 +7,18 @@ #ifndef DDR_PARAMETER_H #define DDR_PARAMETER_H +#include <string.h> + +#include <platform_def.h> + #include <arch_helpers.h> -#include <console.h> -#include <debug.h> -#include <delay_timer.h> -#include <mmio.h> +#include <common/debug.h> +#include <drivers/console.h> +#include <drivers/delay_timer.h> +#include <lib/mmio.h> + #include <plat_private.h> -#include <platform_def.h> #include <soc.h> -#include <string.h> #define DDR_REGION_NR_MAX 10 #define REGION_NR_OFFSET 0 diff --git a/plat/rockchip/common/include/plat_macros.S b/plat/rockchip/common/include/plat_macros.S index 9ee4e83e19..691beeb448 100644 --- a/plat/rockchip/common/include/plat_macros.S +++ b/plat/rockchip/common/include/plat_macros.S @@ -6,10 +6,10 @@ #ifndef ROCKCHIP_PLAT_MACROS_S #define ROCKCHIP_PLAT_MACROS_S -#include <cci.h> -#include <gic_common.h> -#include <gicv2.h> -#include <gicv3.h> +#include <drivers/arm/cci.h> +#include <drivers/arm/gic_common.h> +#include <drivers/arm/gicv2.h> +#include <drivers/arm/gicv3.h> #include <platform_def.h> .section .rodata.gic_reg_name, "aS" diff --git a/plat/rockchip/common/include/plat_private.h b/plat/rockchip/common/include/plat_private.h index 955ca647c5..e8750a5e9f 100644 --- a/plat/rockchip/common/include/plat_private.h +++ b/plat/rockchip/common/include/plat_private.h @@ -8,10 +8,12 @@ #define PLAT_PRIVATE_H #ifndef __ASSEMBLY__ -#include <mmio.h> -#include <psci.h> + #include <stdint.h> -#include <xlat_tables.h> + +#include <lib/psci/psci.h> +#include <lib/xlat_tables/xlat_tables.h> +#include <lib/mmio.h> #define __sramdata __attribute__((section(".sram.data"))) #define __sramconst __attribute__((section(".sram.rodata"))) diff --git a/plat/rockchip/common/params_setup.c b/plat/rockchip/common/params_setup.c index a7ba83e5ac..3d1b40b3ff 100644 --- a/plat/rockchip/common/params_setup.c +++ b/plat/rockchip/common/params_setup.c @@ -5,16 +5,18 @@ */ #include <assert.h> -#include <bl_common.h> -#include <console.h> -#include <coreboot.h> -#include <debug.h> -#include <gpio.h> -#include <mmio.h> +#include <string.h> + +#include <common/bl_common.h> +#include <common/debug.h> +#include <drivers/console.h> +#include <drivers/gpio.h> +#include <lib/coreboot.h> +#include <lib/mmio.h> +#include <plat/common/platform.h> + #include <plat_params.h> #include <plat_private.h> -#include <platform.h> -#include <string.h> static struct gpio_info param_reset; static struct gpio_info param_poweroff; diff --git a/plat/rockchip/common/plat_pm.c b/plat/rockchip/common/plat_pm.c index 352dbc842f..c9563c9ed9 100644 --- a/plat/rockchip/common/plat_pm.c +++ b/plat/rockchip/common/plat_pm.c @@ -4,15 +4,18 @@ * SPDX-License-Identifier: BSD-3-Clause */ -#include <arch_helpers.h> #include <assert.h> -#include <console.h> -#include <debug.h> -#include <delay_timer.h> #include <errno.h> -#include <plat_private.h> + #include <platform_def.h> -#include <psci.h> + +#include <arch_helpers.h> +#include <common/debug.h> +#include <drivers/console.h> +#include <drivers/delay_timer.h> +#include <lib/psci/psci.h> + +#include <plat_private.h> /* Macros to read the rk power domain state */ #define RK_CORE_PWR_STATE(state) \ diff --git a/plat/rockchip/common/plat_topology.c b/plat/rockchip/common/plat_topology.c index 49d063cf57..a31e4103ec 100644 --- a/plat/rockchip/common/plat_topology.c +++ b/plat/rockchip/common/plat_topology.c @@ -4,10 +4,12 @@ * SPDX-License-Identifier: BSD-3-Clause */ +#include <platform_def.h> + #include <arch.h> +#include <lib/psci/psci.h> + #include <plat_private.h> -#include <platform_def.h> -#include <psci.h> /******************************************************************************* * This function returns the RockChip default topology tree information. diff --git a/plat/rockchip/common/rockchip_gicv2.c b/plat/rockchip/common/rockchip_gicv2.c index 4705042baa..222a88261a 100644 --- a/plat/rockchip/common/rockchip_gicv2.c +++ b/plat/rockchip/common/rockchip_gicv2.c @@ -4,11 +4,12 @@ * SPDX-License-Identifier: BSD-3-Clause */ -#include <bl_common.h> -#include <gicv2.h> -#include <interrupt_props.h> #include <platform_def.h> -#include <utils.h> + +#include <common/bl_common.h> +#include <common/interrupt_props.h> +#include <drivers/arm/gicv2.h> +#include <lib/utils.h> /****************************************************************************** * The following functions are defined as weak to allow a platform to override diff --git a/plat/rockchip/common/rockchip_gicv3.c b/plat/rockchip/common/rockchip_gicv3.c index efbf1d167c..edae2efd04 100644 --- a/plat/rockchip/common/rockchip_gicv3.c +++ b/plat/rockchip/common/rockchip_gicv3.c @@ -4,12 +4,13 @@ * SPDX-License-Identifier: BSD-3-Clause */ -#include <bl_common.h> -#include <gicv3.h> -#include <interrupt_props.h> -#include <platform.h> #include <platform_def.h> -#include <utils.h> + +#include <common/bl_common.h> +#include <common/interrupt_props.h> +#include <drivers/arm/gicv3.h> +#include <lib/utils.h> +#include <plat/common/platform.h> /****************************************************************************** * The following functions are defined as weak to allow a platform to override diff --git a/plat/rockchip/common/rockchip_sip_svc.c b/plat/rockchip/common/rockchip_sip_svc.c index d690e92fc9..27ef042c3f 100644 --- a/plat/rockchip/common/rockchip_sip_svc.c +++ b/plat/rockchip/common/rockchip_sip_svc.c @@ -5,12 +5,14 @@ */ #include <assert.h> -#include <debug.h> -#include <mmio.h> + +#include <common/debug.h> +#include <common/runtime_svc.h> +#include <lib/mmio.h> +#include <tools_share/uuid.h> + #include <plat_sip_calls.h> #include <rockchip_sip_svc.h> -#include <runtime_svc.h> -#include <uuid.h> /* Rockchip SiP Service UUID */ DEFINE_SVC_UUID2(rk_sip_svc_uid, |