diff options
author | Antonio Nino Diaz <antonio.ninodiaz@arm.com> | 2018-12-14 00:18:21 +0000 |
---|---|---|
committer | Antonio Nino Diaz <antonio.ninodiaz@arm.com> | 2019-01-04 10:43:17 +0000 |
commit | 09d40e0e08283a249e7dce0e106c07c5141f9b7e (patch) | |
tree | 46e7af7b5be2738948b359b2a07078e4cf1bbec1 /plat/layerscape/board/ls1043 | |
parent | f5478dedf9e096d9539362b38ceb096b940ba3e2 (diff) | |
download | trusted-firmware-a-09d40e0e08283a249e7dce0e106c07c5141f9b7e.tar.gz |
Sanitise includes across codebase
Enforce full include path for includes. Deprecate old paths.
The following folders inside include/lib have been left unchanged:
- include/lib/cpus/${ARCH}
- include/lib/el3_runtime/${ARCH}
The reason for this change is that having a global namespace for
includes isn't a good idea. It defeats one of the advantages of having
folders and it introduces problems that are sometimes subtle (because
you may not know the header you are actually including if there are two
of them).
For example, this patch had to be created because two headers were
called the same way: e0ea0928d5b7 ("Fix gpio includes of mt8173 platform
to avoid collision."). More recently, this patch has had similar
problems: 46f9b2c3a282 ("drivers: add tzc380 support").
This problem was introduced in commit 4ecca33988b9 ("Move include and
source files to logical locations"). At that time, there weren't too
many headers so it wasn't a real issue. However, time has shown that
this creates problems.
Platforms that want to preserve the way they include headers may add the
removed paths to PLAT_INCLUDES, but this is discouraged.
Change-Id: I39dc53ed98f9e297a5966e723d1936d6ccf2fc8f
Signed-off-by: Antonio Nino Diaz <antonio.ninodiaz@arm.com>
Diffstat (limited to 'plat/layerscape/board/ls1043')
-rw-r--r-- | plat/layerscape/board/ls1043/include/ls_def.h | 10 | ||||
-rw-r--r-- | plat/layerscape/board/ls1043/include/platform_def.h | 7 | ||||
-rw-r--r-- | plat/layerscape/board/ls1043/ls1043_bl1_setup.c | 7 | ||||
-rw-r--r-- | plat/layerscape/board/ls1043/ls1043_bl2_setup.c | 5 | ||||
-rw-r--r-- | plat/layerscape/board/ls1043/ls1043_bl31_setup.c | 5 | ||||
-rw-r--r-- | plat/layerscape/board/ls1043/ls1043_err.c | 5 | ||||
-rw-r--r-- | plat/layerscape/board/ls1043/ls1043_psci.c | 18 | ||||
-rw-r--r-- | plat/layerscape/board/ls1043/ls1043_stack_protector.c | 3 | ||||
-rw-r--r-- | plat/layerscape/board/ls1043/ls1043_topology.c | 4 | ||||
-rw-r--r-- | plat/layerscape/board/ls1043/ls_gic.c | 9 | ||||
-rw-r--r-- | plat/layerscape/board/ls1043/platform.mk | 4 |
11 files changed, 44 insertions, 33 deletions
diff --git a/plat/layerscape/board/ls1043/include/ls_def.h b/plat/layerscape/board/ls1043/include/ls_def.h index 9c837204e0..d8c66e3118 100644 --- a/plat/layerscape/board/ls1043/include/ls_def.h +++ b/plat/layerscape/board/ls1043/include/ls_def.h @@ -7,13 +7,13 @@ #ifndef LS_DEF_H #define LS_DEF_H -#include <arch.h> -#include <common_def.h> #include <platform_def.h> -#include <tbbr_img_def.h> -#include <utils_def.h> -#include <xlat_tables_defs.h> +#include <arch.h> +#include <common/tbbr/tbbr_img_def.h> +#include <lib/xlat_tables/xlat_tables_defs.h> +#include <lib/utils_def.h> +#include <plat/common/common_def.h> /****************************************************************************** * Definitions common to all ARM standard platforms diff --git a/plat/layerscape/board/ls1043/include/platform_def.h b/plat/layerscape/board/ls1043/include/platform_def.h index 46b2031e13..b6130001c4 100644 --- a/plat/layerscape/board/ls1043/include/platform_def.h +++ b/plat/layerscape/board/ls1043/include/platform_def.h @@ -7,9 +7,10 @@ #ifndef PLATFORM_DEF_H #define PLATFORM_DEF_H -#include <common_def.h> -#include <tzc400.h> -#include <utils.h> +#include <drivers/arm/tzc400.h> +#include <lib/utils.h> +#include <plat/common/common_def.h> + #include "ls_def.h" #define FIRMWARE_WELCOME_STR_LS1043 "Welcome to LS1043 BL1 Phase\n" diff --git a/plat/layerscape/board/ls1043/ls1043_bl1_setup.c b/plat/layerscape/board/ls1043/ls1043_bl1_setup.c index e82a1fb86b..dfa4725431 100644 --- a/plat/layerscape/board/ls1043/ls1043_bl1_setup.c +++ b/plat/layerscape/board/ls1043/ls1043_bl1_setup.c @@ -4,9 +4,10 @@ * SPDX-License-Identifier: BSD-3-Clause */ -#include <cci.h> -#include <debug.h> -#include <mmio.h> +#include <common/debug.h> +#include <drivers/arm/cci.h> +#include <lib/mmio.h> + #include "plat_ls.h" static const int cci_map[] = { diff --git a/plat/layerscape/board/ls1043/ls1043_bl2_setup.c b/plat/layerscape/board/ls1043/ls1043_bl2_setup.c index b529aa50f9..c9db814776 100644 --- a/plat/layerscape/board/ls1043/ls1043_bl2_setup.c +++ b/plat/layerscape/board/ls1043/ls1043_bl2_setup.c @@ -4,8 +4,9 @@ * SPDX-License-Identifier: BSD-3-Clause */ -#include <mmio.h> -#include <debug.h> +#include <common/debug.h> +#include <lib/mmio.h> + #include "plat_ls.h" void bl2_early_platform_setup2(u_register_t arg0, u_register_t arg1, diff --git a/plat/layerscape/board/ls1043/ls1043_bl31_setup.c b/plat/layerscape/board/ls1043/ls1043_bl31_setup.c index 3473d98831..6d15c11394 100644 --- a/plat/layerscape/board/ls1043/ls1043_bl31_setup.c +++ b/plat/layerscape/board/ls1043/ls1043_bl31_setup.c @@ -4,8 +4,9 @@ * SPDX-License-Identifier: BSD-3-Clause */ -#include <cci.h> -#include <debug.h> +#include <common/debug.h> +#include <drivers/arm/cci.h> + #include "plat_ls.h" #include "fsl_csu.h" diff --git a/plat/layerscape/board/ls1043/ls1043_err.c b/plat/layerscape/board/ls1043/ls1043_err.c index e4a2cae4e3..37077d4d8d 100644 --- a/plat/layerscape/board/ls1043/ls1043_err.c +++ b/plat/layerscape/board/ls1043/ls1043_err.c @@ -4,11 +4,12 @@ * SPDX-License-Identifier: BSD-3-Clause */ -#include <arch_helpers.h> -#include <debug.h> #include <errno.h> #include <stdint.h> +#include <arch_helpers.h> +#include <common/debug.h> + /* * Error handler */ diff --git a/plat/layerscape/board/ls1043/ls1043_psci.c b/plat/layerscape/board/ls1043/ls1043_psci.c index b402e7f772..d6429c3261 100644 --- a/plat/layerscape/board/ls1043/ls1043_psci.c +++ b/plat/layerscape/board/ls1043/ls1043_psci.c @@ -4,17 +4,19 @@ * SPDX-License-Identifier: BSD-3-Clause */ -#include <arch_helpers.h> #include <assert.h> -#include <debug.h> -#include <delay_timer.h> #include <endian.h> #include <errno.h> -#include <gicv2.h> -#include <mmio.h> -#include <platform.h> -#include <psci.h> -#include "platform_def.h" + +#include <platform_def.h> + +#include <arch_helpers.h> +#include <common/debug.h> +#include <drivers/arm/gicv2.h> +#include <drivers/delay_timer.h> +#include <lib/mmio.h> +#include <lib/psci/psci.h> +#include <plat/common/platform.h> #define LS_SCFG_BASE 0x01570000 /* register to store warm boot entry, big endian, higher 32bit */ diff --git a/plat/layerscape/board/ls1043/ls1043_stack_protector.c b/plat/layerscape/board/ls1043/ls1043_stack_protector.c index 50f463b9a0..8a1a4e57d4 100644 --- a/plat/layerscape/board/ls1043/ls1043_stack_protector.c +++ b/plat/layerscape/board/ls1043/ls1043_stack_protector.c @@ -4,9 +4,10 @@ * SPDX-License-Identifier: BSD-3-Clause */ -#include <arch_helpers.h> #include <stdint.h> +#include <arch_helpers.h> + #define RANDOM_CANARY_VALUE ((u_register_t) 3288484550995823360ULL) u_register_t plat_get_stack_protector_canary(void) diff --git a/plat/layerscape/board/ls1043/ls1043_topology.c b/plat/layerscape/board/ls1043/ls1043_topology.c index 12d2830fe3..c9c6a9cc5a 100644 --- a/plat/layerscape/board/ls1043/ls1043_topology.c +++ b/plat/layerscape/board/ls1043/ls1043_topology.c @@ -5,7 +5,9 @@ */ #include <arch.h> -#include <cassert.h> + +#include <lib/cassert.h> + #include "plat_ls.h" #include "platform_def.h" diff --git a/plat/layerscape/board/ls1043/ls_gic.c b/plat/layerscape/board/ls1043/ls_gic.c index 3986153a28..3d8b262d29 100644 --- a/plat/layerscape/board/ls1043/ls_gic.c +++ b/plat/layerscape/board/ls1043/ls_gic.c @@ -4,10 +4,13 @@ * SPDX-License-Identifier: BSD-3-Clause */ -#include <mmio.h> -#include <debug.h> #include <endian.h> -#include "platform_def.h" + +#include <platform_def.h> + +#include <common/debug.h> +#include <lib/mmio.h> + #include "soc.h" /* diff --git a/plat/layerscape/board/ls1043/platform.mk b/plat/layerscape/board/ls1043/platform.mk index 795d924828..91a14a445c 100644 --- a/plat/layerscape/board/ls1043/platform.mk +++ b/plat/layerscape/board/ls1043/platform.mk @@ -23,9 +23,7 @@ LS1043_SECURITY_SOURCES := plat/layerscape/common/ls_tzc380.c \ PLAT_INCLUDES := -Iplat/layerscape/board/ls1043/include \ -Iplat/layerscape/common/include \ - -Iinclude/drivers/arm \ - -Iinclude/lib \ - -Iinclude/drivers/io + -Iinclude/lib PLAT_BL_COMMON_SOURCES := plat/layerscape/common/aarch64/ls_console.S |