path: root/include/plat/common/platform.h
diff options
authorDeepika Bhavnani <deepika.bhavnani@arm.com>2019-12-13 10:23:18 -0600
committerDeepika Bhavnani <deepika.bhavnani@arm.com>2020-01-10 17:11:51 +0000
commit5b33ad174a03a5ccdcd6321c64d69167361dc21a (patch)
tree9842f133951cf7cfec97ac1f10f9f0a1568c230e /include/plat/common/platform.h
parent22d12c4148c373932a7a81e5d1c59a767e143ac2 (diff)
Unify type of "cpu_idx" across PSCI module.
NOTE for platform integrators: API `plat_psci_stat_get_residency()` third argument `last_cpu_idx` is changed from "signed int" to the "unsigned int" type. Issue / Trouble points 1. cpu_idx is used as mix of `unsigned int` and `signed int` in code with typecasting at some places leading to coverity issues. 2. Underlying platform API's return cpu_idx as `unsigned int` and comparison is performed with platform specific defines `PLAFORM_xxx` which is not consistent Misra Rule 10.4: The value of a complex expression of integer type may only be cast to a type that is narrower and of the same signedness as the underlying type of the expression. Based on above points, cpu_idx is kept as `unsigned int` to match the API's and low-level functions and platform defines are updated where ever required Signed-off-by: Deepika Bhavnani <deepika.bhavnani@arm.com> Change-Id: Ib26fd16e420c35527204b126b9b91e8babcc3a5c
Diffstat (limited to 'include/plat/common/platform.h')
1 files changed, 1 insertions, 1 deletions
diff --git a/include/plat/common/platform.h b/include/plat/common/platform.h
index 9efb2fd526..332cfca8d7 100644
--- a/include/plat/common/platform.h
+++ b/include/plat/common/platform.h
@@ -237,7 +237,7 @@ void plat_psci_stat_accounting_start(const psci_power_state_t *state_info);
void plat_psci_stat_accounting_stop(const psci_power_state_t *state_info);
u_register_t plat_psci_stat_get_residency(unsigned int lvl,
const psci_power_state_t *state_info,
- int last_cpu_idx);
+ unsigned int last_cpu_idx);
plat_local_state_t plat_get_target_pwr_state(unsigned int lvl,
const plat_local_state_t *states,
unsigned int ncpu);