diff options
author | Masahiro Yamada <yamada.masahiro@socionext.com> | 2020-03-26 13:16:33 +0900 |
---|---|---|
committer | Masahiro Yamada <yamada.masahiro@socionext.com> | 2020-04-02 13:38:24 +0900 |
commit | a7739bc7b16bf3e43f370864f8a800cf8943b391 (patch) | |
tree | bdd3f96b4e584eb3b4066a8244a388449e4cf8d6 /include/common | |
parent | 0a0a7a9ac82cb79af91f098cedc69cc67bca3978 (diff) | |
download | trusted-firmware-a-a7739bc7b16bf3e43f370864f8a800cf8943b391.tar.gz |
linker_script: move bss section to bl_common.ld.h
Move the bss section to the common header. This adds BAKERY_LOCK_NORMAL
and PMF_TIMESTAMP, which previously existed only in BL31. This is not
a big deal because unused data should not be compiled in the first
place. I believe this should be controlled by BL*_SOURCES in Makefiles,
not by linker scripts.
I investigated BL1, BL2, BL2U, BL31 for plat=fvp, and BL2-AT-EL3,
BL31, BL31 for plat=uniphier. I did not see any more unexpected
code addition.
The bss section has bigger alignment. I added BSS_ALIGN for this.
Currently, SORT_BY_ALIGNMENT() is missing in sp_min.ld.S, and with this
change, the BSS symbols in SP_MIN will be sorted by the alignment.
This is not a big deal (or, even better in terms of the image size).
Change-Id: I680ee61f84067a559bac0757f9d03e73119beb33
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Diffstat (limited to 'include/common')
-rw-r--r-- | include/common/bl_common.ld.h | 18 |
1 files changed, 18 insertions, 0 deletions
diff --git a/include/common/bl_common.ld.h b/include/common/bl_common.ld.h index 5c5fe5b15e..3fc8e970d6 100644 --- a/include/common/bl_common.ld.h +++ b/include/common/bl_common.ld.h @@ -11,8 +11,10 @@ #ifdef __aarch64__ #define STRUCT_ALIGN 8 +#define BSS_ALIGN 16 #else #define STRUCT_ALIGN 4 +#define BSS_ALIGN 8 #endif #define CPU_OPS \ @@ -127,6 +129,22 @@ . = . + (__PERCPU_TIMESTAMP_SIZE__ * (PLATFORM_CORE_COUNT - 1)); \ __PMF_TIMESTAMP_END__ = .; + +/* + * The .bss section gets initialised to 0 at runtime. + * Its base address has bigger alignment for better performance of the + * zero-initialization code. + */ +#define BSS_SECTION \ + .bss (NOLOAD) : ALIGN(BSS_ALIGN) { \ + __BSS_START__ = .; \ + *(SORT_BY_ALIGNMENT(.bss*)) \ + *(COMMON) \ + BAKERY_LOCK_NORMAL \ + PMF_TIMESTAMP \ + __BSS_END__ = .; \ + } + /* * The xlat_table section is for full, aligned page tables (4K). * Removing them from .bss avoids forcing 4K alignment on |