diff options
author | Jimmy Brisson <jimmy.brisson@arm.com> | 2020-08-05 13:44:05 -0500 |
---|---|---|
committer | laurenw-arm <lauren.wehrmeister@arm.com> | 2020-10-09 10:21:50 -0500 |
commit | 831b0e9824e6c7cb07308830c12977acb79156c7 (patch) | |
tree | b36c5ee1945761c86823380b6763d7f143c30210 /drivers/console/multi_console.c | |
parent | bb68a9d602e456dad89fbfc777cb435059d42964 (diff) | |
download | trusted-firmware-a-831b0e9824e6c7cb07308830c12977acb79156c7.tar.gz |
Don't return error information from console_flush
And from crash_console_flush.
We ignore the error information return by console_flush in _every_
place where we call it, and casting the return type to void does not
work around the MISRA violation that this causes. Instead, we collect
the error information from the driver (to avoid changing that API), and
don't return it to the caller.
Change-Id: I1e35afe01764d5c8f0efd04f8949d333ffb688c1
Signed-off-by: Jimmy Brisson <jimmy.brisson@arm.com>
Diffstat (limited to 'drivers/console/multi_console.c')
-rw-r--r-- | drivers/console/multi_console.c | 9 |
1 files changed, 2 insertions, 7 deletions
diff --git a/drivers/console/multi_console.c b/drivers/console/multi_console.c index 0665f202f8..08b8e9fb17 100644 --- a/drivers/console/multi_console.c +++ b/drivers/console/multi_console.c @@ -119,17 +119,12 @@ int console_getc(void) return err; } -int console_flush(void) +void console_flush(void) { - int err = ERROR_NO_VALID_CONSOLE; console_t *console; for (console = console_list; console != NULL; console = console->next) if ((console->flags & console_state) && (console->flush != NULL)) { - int ret = console->flush(console); - if ((err == ERROR_NO_VALID_CONSOLE) || (ret < err)) - err = ret; + console->flush(console); } - - return err; } |