aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNaman Patel <naman.patel@amd.com>2022-11-16 01:54:23 -0800
committerNaman Patel <naman.patel@amd.com>2022-11-24 05:25:48 -0800
commitcd73d62b0e0920ca4e6c4fea7ab65bcbd63e07de (patch)
treeb463fce96b06029622ff55d5a94485e217603b58
parent98d83b9971c769905ff489c670a3eebc2891b9fc (diff)
downloadtrusted-firmware-a-cd73d62b0e0920ca4e6c4fea7ab65bcbd63e07de.tar.gz
fix(versal): initialize the variable with value 0 in pm code
Remove zeromem function as the array is already initialized with value 0. MISRA Violation: MISRA C-2012 Rule 9.1 - Initialize the array/variable with a value 0 to resolve the misra warnings in pm_service component. Signed-off-by: Naman Patel <naman.patel@amd.com> Change-Id: I1a3d44a7ae4088a3034eb0119d82b99cd4617ccd
-rw-r--r--plat/xilinx/versal/pm_service/pm_client.c4
-rw-r--r--plat/xilinx/versal/pm_service/pm_svc_main.c2
2 files changed, 2 insertions, 4 deletions
diff --git a/plat/xilinx/versal/pm_service/pm_client.c b/plat/xilinx/versal/pm_service/pm_client.c
index ce5e53384a..54f4eb285b 100644
--- a/plat/xilinx/versal/pm_service/pm_client.c
+++ b/plat/xilinx/versal/pm_service/pm_client.c
@@ -120,11 +120,9 @@ static void pm_client_set_wakeup_sources(uint32_t node_id)
{
uint32_t reg_num;
uint32_t device_id;
- uint8_t pm_wakeup_nodes_set[XPM_NODEIDX_DEV_MAX];
+ uint8_t pm_wakeup_nodes_set[XPM_NODEIDX_DEV_MAX] = { 0U };
uintptr_t isenabler1 = PLAT_VERSAL_GICD_BASE + GICD_ISENABLER + 4;
- zeromem(&pm_wakeup_nodes_set, (u_register_t)sizeof(pm_wakeup_nodes_set));
-
for (reg_num = 0U; reg_num < NUM_GICD_ISENABLER; reg_num++) {
uint32_t base_irq = reg_num << ISENABLER_SHIFT;
uint32_t reg = mmio_read_32(isenabler1 + (reg_num << 2));
diff --git a/plat/xilinx/versal/pm_service/pm_svc_main.c b/plat/xilinx/versal/pm_service/pm_svc_main.c
index 9eb426a374..c90f9e1c34 100644
--- a/plat/xilinx/versal/pm_service/pm_svc_main.c
+++ b/plat/xilinx/versal/pm_service/pm_svc_main.c
@@ -160,7 +160,7 @@ static uintptr_t eemi_for_compatibility(uint32_t api_id, uint32_t *pm_arg,
case PM_IOCTL:
{
- uint32_t value;
+ uint32_t value = 0U;
ret = pm_api_ioctl(pm_arg[0], pm_arg[1], pm_arg[2],
pm_arg[3], pm_arg[4],