aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndre Przywara <andre.przywara@arm.com>2020-10-02 11:54:56 +0100
committerAlexei Fedorov <Alexei.Fedorov@arm.com>2020-10-02 12:14:02 +0000
commit6e4da01ffbf42bf97933d72868f38aa378313698 (patch)
tree2b837127665fd1478b761b9e52154d44d9988e1d
parent14bac449fa29c9576abdda36b4e8f77deb99d9bb (diff)
downloadtrusted-firmware-a-6e4da01ffbf42bf97933d72868f38aa378313698.tar.gz
spmd: Fix signedness comparison warning
With -Wsign-compare, compilers issue a warning in the SPMD code: ==================== services/std_svc/spmd/spmd_pm.c:35:22: error: comparison of integer expressions of different signedness: 'int' and 'unsigned int' [-Werror=sign-compare] 35 | if ((id < 0) || (id >= PLATFORM_CORE_COUNT)) { | ^~ cc1: all warnings being treated as errors ==================== Since we just established that "id" is positive, we can safely cast it to an unsigned type to make the comparison have matching types. Change-Id: I6ef24804c88136d7e3f15de008e4fea854f10ffe Signed-off-by: Andre Przywara <andre.przywara@arm.com>
-rw-r--r--services/std_svc/spmd/spmd_pm.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/services/std_svc/spmd/spmd_pm.c b/services/std_svc/spmd/spmd_pm.c
index 64ddbe5f40..5433e5d257 100644
--- a/services/std_svc/spmd/spmd_pm.c
+++ b/services/std_svc/spmd/spmd_pm.c
@@ -32,7 +32,7 @@ int spmd_pm_secondary_core_set_ep(unsigned long long mpidr,
{
int id = plat_core_pos_by_mpidr(mpidr);
- if ((id < 0) || (id >= PLATFORM_CORE_COUNT)) {
+ if ((id < 0) || ((unsigned int)id >= PLATFORM_CORE_COUNT)) {
ERROR("%s inconsistent MPIDR (%llx)\n", __func__, mpidr);
return -EINVAL;
}