diff options
Diffstat (limited to 'spm/cactus')
-rw-r--r-- | spm/cactus/cactus_def.h | 14 | ||||
-rw-r--r-- | spm/cactus/cactus_ffa_tests.c | 154 | ||||
-rw-r--r-- | spm/cactus/cactus_main.c | 21 | ||||
-rw-r--r-- | spm/cactus/cactus_tests.h | 4 | ||||
-rw-r--r-- | spm/cactus/cactus_tests_misc.c | 41 |
5 files changed, 175 insertions, 59 deletions
diff --git a/spm/cactus/cactus_def.h b/spm/cactus/cactus_def.h index a0adb2343..0d3df2e4e 100644 --- a/spm/cactus/cactus_def.h +++ b/spm/cactus/cactus_def.h @@ -28,4 +28,18 @@ #define CACTUS_TX_BASE CACTUS_RX_BASE + PAGE_SIZE #define CACTUS_RX_TX_SIZE PAGE_SIZE * 2 +/* + * RX/TX buffer helpers. + */ +#define get_sp_rx_start(sp_id) (CACTUS_RX_BASE + ((sp_id - 1) * CACTUS_RX_TX_SIZE)) +#define get_sp_rx_end(sp_id) (CACTUS_RX_BASE + ((sp_id - 1) * CACTUS_RX_TX_SIZE) + PAGE_SIZE) +#define get_sp_tx_start(sp_id) (CACTUS_TX_BASE + ((sp_id - 1) * CACTUS_RX_TX_SIZE)) +#define get_sp_tx_end(sp_id) (CACTUS_TX_BASE + ((sp_id - 1) * CACTUS_RX_TX_SIZE) + PAGE_SIZE) + +/* + * UUID of secure partition as defined in the respective manifests. + */ +#define PRIMARY_UUID {0xb4b5671e, 0x4a904fe1, 0xb81ffb13, 0xdae1dacb} +#define SECONDARY_UUID {0xd1582309, 0xf02347b9, 0x827c4464, 0xf5578fc8} + #endif /* CACTUS_DEF_H */ diff --git a/spm/cactus/cactus_ffa_tests.c b/spm/cactus/cactus_ffa_tests.c index 411cc9f2e..25c20b004 100644 --- a/spm/cactus/cactus_ffa_tests.c +++ b/spm/cactus/cactus_ffa_tests.c @@ -4,8 +4,9 @@ * SPDX-License-Identifier: BSD-3-Clause */ #include <assert.h> -#include <errno.h> #include <debug.h> +#include <errno.h> +#include <cactus_def.h> #include <ffa_helpers.h> #include <sp_helpers.h> @@ -13,20 +14,146 @@ #define FFA_MAJOR 1U #define FFA_MINOR 0U -void ffa_tests(void) +static const uint32_t primary_uuid[4] = PRIMARY_UUID; +static const uint32_t secondary_uuid[4] = SECONDARY_UUID; +static const uint32_t null_uuid[4] = {0}; + +struct feature_test { + const char *test_name; + unsigned int feature; + unsigned int expected_ret; +}; + +static const struct feature_test test_target[] = { + {"FFA_ERROR_32 check", FFA_ERROR, FFA_SUCCESS_SMC32}, + {"FFA_SUCCESS_32 check", FFA_SUCCESS_SMC32, FFA_SUCCESS_SMC32}, + {"FFA_INTERRUPT_32 check", FFA_INTERRUPT, FFA_SUCCESS_SMC32}, + {"FFA_VERSION_32 check", FFA_VERSION, FFA_SUCCESS_SMC32}, + {"FFA_FEATURES_32 check", FFA_FEATURES, FFA_SUCCESS_SMC32}, + {"FFA_RX_RELEASE_32 check", FFA_RX_RELEASE, FFA_SUCCESS_SMC32}, + {"FFA_RXTX_MAP_32 check", FFA_RXTX_MAP_SMC32, FFA_ERROR}, + {"FFA_RXTX_MAP_64 check", FFA_RXTX_MAP_SMC64, FFA_SUCCESS_SMC32}, + {"FFA_RXTX_UNMAP_32 check", FFA_RXTX_UNMAP, FFA_ERROR}, + {"FFA_PARTITION_INFO_GET_32 check", FFA_PARTITION_INFO_GET, FFA_SUCCESS_SMC32}, + {"FFA_ID_GET_32 check", FFA_ID_GET, FFA_SUCCESS_SMC32}, + {"FFA_MSG_POLL_32 check", FFA_MSG_POLL, FFA_SUCCESS_SMC32}, + {"FFA_MSG_WAIT_32 check", FFA_MSG_WAIT, FFA_SUCCESS_SMC32}, + {"FFA_YIELD_32 check", FFA_MSG_YIELD, FFA_SUCCESS_SMC32}, + {"FFA_RUN_32 check", FFA_MSG_RUN, FFA_SUCCESS_SMC32}, + {"FFA_MSG_SEND_32 check", FFA_MSG_SEND, FFA_SUCCESS_SMC32}, + {"FFA_MEM_DONATE_32 check", FFA_MEM_DONATE_SMC32, FFA_SUCCESS_SMC32}, + {"FFA_MEM_LEND_32 check", FFA_MEM_LEND_SMC32, FFA_SUCCESS_SMC32}, + {"FFA_MEM_SHARE_32 check", FFA_MEM_SHARE_SMC32, FFA_SUCCESS_SMC32}, + {"FFA_MEM_RETRIEVE_REQ_32 check", FFA_MEM_RETRIEVE_REQ_SMC32, FFA_SUCCESS_SMC32}, + {"FFA_MEM_RETRIEVE_RESP_32 check", FFA_MEM_RETRIEVE_RESP, FFA_SUCCESS_SMC32}, + {"FFA_MEM_RELINQUISH_32 check", FFA_MEM_RELINQUISH, FFA_SUCCESS_SMC32}, + {"FFA_MEM_RECLAIM_32 check", FFA_MEM_RECLAIM, FFA_SUCCESS_SMC32}, + {"Check non-existent command", 0xFFFF, FFA_ERROR} +}; + +/* + * Test FFA_FEATURES interface. + */ +static void ffa_features_test(void) { - const char *test_ffa = "FFA Interfaces"; - const char *test_ffa_version = "FFA Version interface"; + const char *test_features = "FFA Features interface"; + smc_ret_values ffa_ret; + unsigned int i, test_target_size = + sizeof(test_target) / sizeof(struct feature_test); - announce_test_section_start(test_ffa); + announce_test_section_start(test_features); + + for (i = 0U; i < test_target_size; i++) { + announce_test_start(test_target[i].test_name); + + ffa_ret = ffa_features(test_target[i].feature); + expect(ffa_ret.ret0, test_target[i].expected_ret); + if (test_target[i].expected_ret == FFA_ERROR) { + expect(ffa_ret.ret2, FFA_ERROR_NOT_SUPPORTED); + } + + announce_test_end(test_target[i].test_name); + } + + announce_test_section_end(test_features); +} + +static void ffa_partition_info_helper(struct mailbox_buffers *mb, const uint32_t uuid[4], + const struct ffa_partition_info *expected, + const uint16_t expected_size) +{ + smc_ret_values ret = ffa_partition_info_get(uuid); + unsigned int i; + expect(ret.ret0, FFA_SUCCESS_SMC32); + + struct ffa_partition_info *info = (struct ffa_partition_info *)(mb->recv); + for (i = 0U; i < expected_size; i++) { + expect(info[i].id, expected[i].id); + expect(info[i].exec_context, expected[i].exec_context); + expect(info[i].properties, expected[i].properties); + } + + ret = ffa_rx_release(); + expect(ret.ret0, FFA_SUCCESS_SMC32); +} + +static void ffa_partition_info_wrong_test(void) +{ + const char *test_wrong_uuid = "Request wrong UUID"; + uint32_t uuid[4] = {1}; + + announce_test_start(test_wrong_uuid); + + smc_ret_values ret = ffa_partition_info_get(uuid); + expect(ret.ret0, FFA_ERROR); + expect(ret.ret2, FFA_ERROR_INVALID_PARAMETER); + + announce_test_end(test_wrong_uuid); +} + +static void ffa_partition_info_get_test(struct mailbox_buffers *mb) +{ + const char *test_partition_info = "FFA Partition info interface"; + const char *test_primary = "Get primary partition info"; + const char *test_secondary = "Get secondary partition info"; + const char *test_all = "Get all partitions info"; + + const struct ffa_partition_info expected_info[] = { + {.id = SPM_VM_ID_FIRST, .exec_context = 8, .properties = 0}, /* Primary partition info */ + {.id = 2, .exec_context = 2, .properties = 0} /* Secondary partition info */ + }; + + announce_test_section_start(test_partition_info); + + announce_test_start(test_secondary); + ffa_partition_info_helper(mb, secondary_uuid, &expected_info[1], 1); + announce_test_end(test_secondary); + + announce_test_start(test_primary); + ffa_partition_info_helper(mb, primary_uuid, &expected_info[0], 1); + announce_test_end(test_primary); + + announce_test_start(test_all); + ffa_partition_info_helper(mb, null_uuid, expected_info, 2); + announce_test_end(test_all); + + ffa_partition_info_wrong_test(); + + announce_test_section_end(test_partition_info); +} + +void ffa_version_test(void) +{ + const char *test_ffa_version = "FFA Version interface"; announce_test_start(test_ffa_version); smc_ret_values ret = ffa_version(MAKE_FFA_VERSION(FFA_MAJOR, FFA_MINOR)); - uint32_t spm_version = (uint32_t)(0xFFFFFFFF & ret.ret0); + uint32_t spm_version = (uint32_t)ret.ret0; - bool ffa_version_compatible = ((spm_version >> FFA_VERSION_MAJOR_SHIFT) == FFA_MAJOR && - (spm_version & FFA_VERSION_MINOR_MASK) >= FFA_MINOR); + bool ffa_version_compatible = + ((spm_version >> FFA_VERSION_MAJOR_SHIFT) == FFA_MAJOR && + (spm_version & FFA_VERSION_MINOR_MASK) >= FFA_MINOR); NOTICE("FFA_VERSION returned %u.%u; Compatible: %i\n", spm_version >> FFA_VERSION_MAJOR_SHIFT, @@ -36,6 +163,17 @@ void ffa_tests(void) expect((int)ffa_version_compatible, (int)true); announce_test_end(test_ffa_version); +} + +void ffa_tests(struct mailbox_buffers *mb) +{ + const char *test_ffa = "FFA Interfaces"; + + announce_test_section_start(test_ffa); + + ffa_features_test(); + ffa_version_test(); + ffa_partition_info_get_test(mb); announce_test_section_end(test_ffa); } diff --git a/spm/cactus/cactus_main.c b/spm/cactus/cactus_main.c index 49764eccd..31906d597 100644 --- a/spm/cactus/cactus_main.c +++ b/spm/cactus/cactus_main.c @@ -102,12 +102,12 @@ static void cactus_print_memory_layout(unsigned int vm_id) (void *)CACTUS_BSS_START, (void *)CACTUS_BSS_END); NOTICE(" RX : %p - %p\n", - (void *)(CACTUS_RX_BASE + ((vm_id - 1) * CACTUS_RX_TX_SIZE)), - (void *)(CACTUS_TX_BASE + ((vm_id - 1) * CACTUS_RX_TX_SIZE))); + (void *)get_sp_rx_start(vm_id), + (void *)get_sp_rx_end(vm_id)); NOTICE(" TX : %p - %p\n", - (void *)(CACTUS_TX_BASE + ((vm_id - 1) * CACTUS_RX_TX_SIZE)), - (void *)(CACTUS_RX_BASE + (vm_id * CACTUS_RX_TX_SIZE))); + (void *)get_sp_tx_start(vm_id), + (void *)get_sp_tx_end(vm_id)); } static void cactus_plat_configure_mmu(unsigned int vm_id) @@ -129,13 +129,13 @@ static void cactus_plat_configure_mmu(unsigned int vm_id) CACTUS_BSS_END - CACTUS_BSS_START, MT_RW_DATA); - mmap_add_region((CACTUS_RX_BASE + ((vm_id - 1) * CACTUS_RX_TX_SIZE)), - (CACTUS_RX_BASE + ((vm_id - 1) * CACTUS_RX_TX_SIZE)), + mmap_add_region(get_sp_rx_start(vm_id), + get_sp_rx_start(vm_id), (CACTUS_RX_TX_SIZE / 2), MT_RO_DATA); - mmap_add_region((CACTUS_TX_BASE + ((vm_id - 1) * CACTUS_RX_TX_SIZE)), - (CACTUS_TX_BASE + ((vm_id - 1) * CACTUS_RX_TX_SIZE)), + mmap_add_region(get_sp_tx_start(vm_id), + get_sp_tx_start(vm_id), (CACTUS_RX_TX_SIZE / 2), MT_RW_DATA); @@ -147,6 +147,7 @@ void __dead2 cactus_main(void) { assert(IS_IN_EL1() != 0); + struct mailbox_buffers mb; /* Clear BSS */ memset((void *)CACTUS_BSS_START, 0, CACTUS_BSS_END - CACTUS_BSS_START); @@ -159,6 +160,8 @@ void __dead2 cactus_main(void) } ffa_vm_id_t ffa_id = ffa_id_ret.ret2 & 0xffff; + mb.send = (void *) get_sp_tx_start(ffa_id); + mb.recv = (void *) get_sp_rx_start(ffa_id); /* Configure and enable Stage-1 MMU, enable D-Cache */ cactus_plat_configure_mmu(ffa_id); @@ -190,7 +193,7 @@ void __dead2 cactus_main(void) cactus_print_memory_layout(ffa_id); /* Invoking Tests */ - ffa_tests(); + ffa_tests(&mb); /* End up to message loop */ message_loop(ffa_id); diff --git a/spm/cactus/cactus_tests.h b/spm/cactus/cactus_tests.h index 23586f51a..2e13a6f96 100644 --- a/spm/cactus/cactus_tests.h +++ b/spm/cactus/cactus_tests.h @@ -7,6 +7,8 @@ #ifndef CACTUS_TESTS_H #define CACTUS_TESTS_H +#include <ffa_helpers.h> + /* * Test functions */ @@ -14,7 +16,7 @@ /* * Test to FFA interfaces. */ -void ffa_tests(void); +void ffa_tests(struct mailbox_buffers *mb); /* * Test other things like the version number returned by SPM. diff --git a/spm/cactus/cactus_tests_misc.c b/spm/cactus/cactus_tests_misc.c deleted file mode 100644 index 39eb75222..000000000 --- a/spm/cactus/cactus_tests_misc.c +++ /dev/null @@ -1,41 +0,0 @@ -/* - * Copyright (c) 2018, Arm Limited. All rights reserved. - * - * SPDX-License-Identifier: BSD-3-Clause - */ - -#include <assert.h> -#include <debug.h> -#include <errno.h> -#include <sp_helpers.h> -#include <spm_svc.h> -#include <sprt_client.h> -#include <sprt_svc.h> -#include <stdint.h> - -#include "cactus.h" -#include "cactus_tests.h" - -/* - * Miscellaneous SPM tests. - */ -void misc_tests(void) -{ - int32_t ret; - - const char *test_sect_desc = "miscellaneous"; - - announce_test_section_start(test_sect_desc); - - const char *test_version_sprt = "SPRT version check"; - - announce_test_start(test_version_sprt); - ret = sprt_version(); - INFO("Version = 0x%x (%u.%u)\n", ret, - (ret >> SPRT_VERSION_MAJOR_SHIFT) & SPRT_VERSION_MAJOR_MASK, - ret & SPRT_VERSION_MINOR_MASK); - expect(ret, SPRT_VERSION_COMPILED); - announce_test_end(test_version_sprt); - - announce_test_section_end(test_sect_desc); -} |