diff options
author | Manish V Badarkhe <Manish.Badarkhe@arm.com> | 2020-09-03 16:54:47 +0100 |
---|---|---|
committer | Manish V Badarkhe <Manish.Badarkhe@arm.com> | 2020-09-07 13:00:14 +0100 |
commit | dad2934c4914031019c6f4b7886820d0a6a9bc4b (patch) | |
tree | d14bfbc28e5bfde7de80c58d3c83e39911d445d3 | |
parent | 7ef3e0b31baa6a718e0e99d96e65b82c27a08f0b (diff) | |
download | trusted-firmware-a-dad2934c4914031019c6f4b7886820d0a6a9bc4b.tar.gz |
plat: Fix build issue for qemu and rpi3 platforms
Coverity build periodically throws below errors(non-consistently)
for 'QEMU' and 'RPI3' platforms.
/bin/sh: 1: cannot create build/qemu/debug/rot_key.pem: Directory
nonexistent
plat/qemu/qemu/platform.mk:86: recipe for target 'build/qemu/debug/
rot_key.pem' failed
make: *** [build/qemu/debug/rot_key.pem] Error 2
/bin/sh: 1: cannot create /work/workspace/workspace/tf-coverity/build
/rpi3/debug/rot_key.pem: Directory nonexistent
plat/rpi/rpi3/platform.mk:214: recipe for target '/work/workspace/
workspace/tf-coverity/build/rpi3/debug/rot_key.pem' failed
make: *** [/work/workspace/workspace/tf-coverity/build/rpi3/debug/
rot_key.pem] Error 2
Issue seems to be occurred when 'ROT key' is generated before creating
the platform build folder(for e.g.build/qemu/debug).
Changes are made to fix this issue by adding orderly dependancy of
the platform folder for the 'ROT key' creation which ensures that
platform folder is created before generating 'ROT key'.
Signed-off-by: Manish V Badarkhe <Manish.Badarkhe@arm.com>
Change-Id: I20c82172dde84e4c7f2373c0bd095d353f845d38
-rw-r--r-- | plat/qemu/qemu/platform.mk | 2 | ||||
-rw-r--r-- | plat/rpi/rpi3/platform.mk | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/plat/qemu/qemu/platform.mk b/plat/qemu/qemu/platform.mk index 9441437957..14bf049bed 100644 --- a/plat/qemu/qemu/platform.mk +++ b/plat/qemu/qemu/platform.mk @@ -84,7 +84,7 @@ ifneq (${TRUSTED_BOARD_BOOT},0) certificates: $(ROT_KEY) - $(ROT_KEY): + $(ROT_KEY): | $(BUILD_PLAT) @echo " OPENSSL $@" $(Q)openssl genrsa 2048 > $@ 2>/dev/null diff --git a/plat/rpi/rpi3/platform.mk b/plat/rpi/rpi3/platform.mk index 4d627b8a54..6c239230d9 100644 --- a/plat/rpi/rpi3/platform.mk +++ b/plat/rpi/rpi3/platform.mk @@ -210,7 +210,7 @@ ifneq (${TRUSTED_BOARD_BOOT},0) certificates: $(ROT_KEY) - $(ROT_KEY): + $(ROT_KEY): | $(BUILD_PLAT) @echo " OPENSSL $@" $(Q)openssl genrsa 2048 > $@ 2>/dev/null |